Skip to content

Conversation

@pjohnst5
Copy link
Contributor

@pjohnst5 pjohnst5 commented Aug 4, 2025

Just updating the base golang image again

I'm curious:

  • Is it preferential that I do this in a separate PR every time? (to keep PRs scoped to just 1 thing)
  • Are there any automations to do this sort of thing like dependabot does?

Copilot AI review requested due to automatic review settings August 4, 2025 18:23
@pjohnst5 pjohnst5 requested review from a team as code owners August 4, 2025 18:23
@pjohnst5 pjohnst5 requested a review from tamilmani1989 August 4, 2025 18:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the base golang Docker image across the project by changing the SHA256 hash reference to point to a newer version of the Microsoft golang image.

  • Updates golang base image SHA256 hash from 7d33a8015c48c06e97ecd5139181594b550d4d4d6a9d7fb19083192541213753 to 1c631a31ac7684cf03c7d2dab9b69b06f15f89177baba51421479d29df22177c

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
cns/Dockerfile Updates golang base image SHA256 hash for CNS component
cni/Dockerfile Updates golang base image SHA256 hash for CNI component
Comments suppressed due to low confidence (2)

cns/Dockerfile:8

  • The SHA256 hash 1c631a31ac7684cf03c7d2dab9b69b06f15f89177baba51421479d29df22177c appears to be incomplete. Docker image SHA256 hashes should be 64 characters long, but this hash is only 63 characters. Please verify the correct hash for the golang image.
FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang@sha256:1c631a31ac7684cf03c7d2dab9b69b06f15f89177baba51421479d29df22177c AS go

cni/Dockerfile:9

  • The SHA256 hash 1c631a31ac7684cf03c7d2dab9b69b06f15f89177baba51421479d29df22177c appears to be incomplete. Docker image SHA256 hashes should be 64 characters long, but this hash is only 63 characters. Please verify the correct hash for the golang image.
FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang@sha256:1c631a31ac7684cf03c7d2dab9b69b06f15f89177baba51421479d29df22177c AS go

@pjohnst5
Copy link
Contributor Author

pjohnst5 commented Aug 4, 2025

The reason i do these separately, is let's say I lump it into #3878

Then if we need to revert #3878, the base golang change would also be reverted

So I like to separate them just in case, but also curious others' points of view

@pjohnst5
Copy link
Contributor Author

pjohnst5 commented Aug 4, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@pjohnst5
Copy link
Contributor Author

pjohnst5 commented Aug 4, 2025

@jpayne3506 would you be able to review this for me please? 🙏🏻

@jpayne3506
Copy link
Contributor

@rbtr This looks to be consistent pain point for people. IMO, I would want this to be updated before every release, but I also don't want this to be put onto every PR as it would impact backports ect.

Are there any automations to do this sort of thing like dependabot does?

I have seen solutions with Renovate, but I don't believe dependabot updates we have not been using dependabot correctly for our dockerfiles. We can test it out with a follow on PR.

@rbtr
Copy link
Collaborator

rbtr commented Aug 4, 2025

it's not a blocking check

@pjohnst5 pjohnst5 enabled auto-merge August 4, 2025 23:47
@pjohnst5
Copy link
Contributor Author

pjohnst5 commented Aug 4, 2025

@rbtr would you be willing to approve this one?

@pjohnst5 pjohnst5 added this pull request to the merge queue Aug 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 6, 2025
@pjohnst5 pjohnst5 added this pull request to the merge queue Aug 6, 2025
@pjohnst5 pjohnst5 removed this pull request from the merge queue due to a manual request Aug 6, 2025
@rbtr rbtr closed this Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants