-
Notifications
You must be signed in to change notification settings - Fork 260
Updating base golang image #3886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the base golang Docker image across the project by changing the SHA256 hash reference to point to a newer version of the Microsoft golang image.
- Updates golang base image SHA256 hash from
7d33a8015c48c06e97ecd5139181594b550d4d4d6a9d7fb19083192541213753to1c631a31ac7684cf03c7d2dab9b69b06f15f89177baba51421479d29df22177c
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cns/Dockerfile | Updates golang base image SHA256 hash for CNS component |
| cni/Dockerfile | Updates golang base image SHA256 hash for CNI component |
Comments suppressed due to low confidence (2)
cns/Dockerfile:8
- The SHA256 hash
1c631a31ac7684cf03c7d2dab9b69b06f15f89177baba51421479d29df22177cappears to be incomplete. Docker image SHA256 hashes should be 64 characters long, but this hash is only 63 characters. Please verify the correct hash for the golang image.
FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang@sha256:1c631a31ac7684cf03c7d2dab9b69b06f15f89177baba51421479d29df22177c AS go
cni/Dockerfile:9
- The SHA256 hash
1c631a31ac7684cf03c7d2dab9b69b06f15f89177baba51421479d29df22177cappears to be incomplete. Docker image SHA256 hashes should be 64 characters long, but this hash is only 63 characters. Please verify the correct hash for the golang image.
FROM --platform=linux/${ARCH} mcr.microsoft.com/oss/go/microsoft/golang@sha256:1c631a31ac7684cf03c7d2dab9b69b06f15f89177baba51421479d29df22177c AS go
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@jpayne3506 would you be able to review this for me please? 🙏🏻 |
|
@rbtr This looks to be consistent pain point for people. IMO, I would want this to be updated before every release, but I also don't want this to be put onto every PR as it would impact backports ect.
I have seen solutions with Renovate, but |
|
it's not a blocking check |
|
@rbtr would you be willing to approve this one? |
Just updating the base golang image again
I'm curious: