Azure-NPM code refactoring #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

saiyan86 merged 69 commits into Azure:master from saiyan86:mergePolicies

Aug 30, 2019

Contributor

saiyan86 commented Aug 12, 2019 •

edited

Loading

What this PR does / why we need it:

This PR

merges all networkpolicies targeting the same podselector together, and
simplifies logic of parsing code, and
adds auto-comment generation feature, and
improves test coverage.

Special notes for your reviewer:

Release note:

N/A

Yongli Chen added 30 commits

April 2, 2019 15:38


          parse selectors to kv based labels

f4b7352


          TestsplitPolicy

61acc0b


          ParseLabel

3dbbd36


          addPolicy

d4ec358


          start deductPolicy

557c25f


          deduct network policy

341b0ad


          remvoe redundant print

4db9122


          Merge branch 'master' into mergePolicies

77c36fc


          TestDeductPolicy

217d1a7


          Merge branch 'master' into mergePolicies

1dfe4b6


          translatePolicy

14b8338


          try build

36301c4


          print policy

6b81fd6


          record newPolicy

6f5f827


          pass in addedPolicy

1b4d2a1


          translateIngress


          comma

bd509be


          fix build err

3d6d7da


          fix build err

4fed131


          remove

ae390d6


          change telemetry to message queue and add npm

44c4f4c


          remove [Azure-NPM] prefix

ef51b86


          remove npmreport url

44e5f07


          merge with telemetry changes

c647f71


          fair scheduling

7c821ed


          holds up to 1k reports for each type


          fix cap on reports

5aa60e9


          Merge branch 'npmTelemetry' into mergePolicies

d2e9315


          rename const


          handle ingress port rules

5441b4c

jaer-tsun reviewed

View reviewed changes

npm/iptm/iptm.go Show resolved Hide resolved


          access selector through sorted order

bda22cd

jaer-tsun reviewed

View reviewed changes

npm/nwpolicy.go Show resolved Hide resolved

jaer-tsun reviewed

View reviewed changes

npm/parsePolicy.go Show resolved Hide resolved

jaer-tsun reviewed

View reviewed changes

npm/parsePolicy.go Show resolved Hide resolved

jaer-tsun reviewed

View reviewed changes

npm/parsePolicy.go Outdated Show resolved Hide resolved


          normal networkpolicies unit tests done

534767c

jaer-tsun reviewed

View reviewed changes

npm/plugin/main.go Outdated Show resolved Hide resolved

jaer-tsun reviewed

View reviewed changes

npm/pod.go Outdated Show resolved Hide resolved


          remove extra ns-

17fa5a3

jaer-tsun reviewed

View reviewed changes

npm/translatePolicy.go Show resolved Hide resolved

jaer-tsun reviewed

View reviewed changes

npm/translatePolicy.go Show resolved Hide resolved

jaer-tsun reviewed

View reviewed changes

npm/translatePolicy.go Show resolved Hide resolved


          finished translatePolicy unit tests

eef1363

jaer-tsun reviewed

View reviewed changes

npm/translatePolicy.go Show resolved Hide resolved


          merge with master

3e0c0bf

saiyan86 force-pushed the mergePolicies branch from accaa50 to 471457a Compare

August 29, 2019 23:05


          address jaeryn's comments

65c6ce6

saiyan86 force-pushed the mergePolicies branch from 471457a to 65c6ce6 Compare

August 29, 2019 23:06

Ubuntu added 3 commits

August 30, 2019 01:20


          add AZURE-NPM-KUBE-SYSTEM chain

5a3d5cd


          use nsName

20db12f


          process rules separately

d5ea6a3

saiyan86 requested a review from matmerr

August 30, 2019 17:19


          defer translatePolicy result print

ae2ccf3

jaer-tsun approved these changes

View reviewed changes

Contributor

jaer-tsun left a comment

lgtm

matmerr approved these changes

View reviewed changes

saiyan86 merged commit 36f188c into Azure:master

saiyan86 deleted the mergePolicies branch

August 30, 2019 21:02

saiyan86 changed the title ~~[WIP - DO NOT MERGE] Merge policies~~ Merge policies

saiyan86 changed the title ~~Merge policies~~ Azure-NPM code refactoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet