chore: update to go1.24 #3912
Merged
chore: update to go1.24 #3912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpayne3506
requested review from
a team,
QxBytes,
ZetaoZhuang,
ashvindeodhar,
camrynl,
paulyufan2,
rbtr,
santhoshmprabhu and
thatmattlong
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the Go runtime from version 1.23 to 1.24.0 across the Azure Container Networking project. It consolidates tool management by moving from separate tool binaries to leveraging Go 1.24's built-in tool support and removes several obsolete toolbox components.
- Upgrades Go version from 1.23.x to 1.24.0 across all modules and Docker images
- Refactors tool management to use
go toolcommands instead of separate binary builds - Removes deprecated toolbox server and manifest files
Reviewed Changes
Copilot reviewed 46 out of 50 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod, zapai/go.mod, dropgz/go.mod, etc. | Update Go version to 1.24.0 and related dependency versions |
| tools.go.mod | Restructure from traditional require statements to Go 1.24's tool directive |
| Makefile, platform/Makefile, various CRD Makefiles | Replace tool binary paths with go tool commands |
| Dockerfiles | Update base Go images to 1.24 versions with new SHA digests |
| hack/toolbox/* | Remove deprecated toolbox server implementation and manifests |
| GitHub workflows | Update to use go-version-file instead of hardcoded versions |
jpayne3506
force-pushed
the
jpayne/go1.24
branch
11 times, most recently
from
2dff178 to
a507f8c
Compare
rbtr
reviewed
Aug 8, 2025
rbtr
reviewed
Aug 8, 2025
jpayne3506
force-pushed
the
jpayne/go1.24
branch
from
e769fca to
2fd7b43
Compare
jpayne3506
force-pushed
the
jpayne/go1.24
branch
2 times, most recently
from
b59c6c7 to
5d03f82
Compare
jpayne3506
force-pushed
the
jpayne/go1.24
branch
from
5d03f82 to
85987cd
Compare
santhoshmprabhu
approved these changes
Sep 4, 2025
|
/azp run NPM Scale Test, NPM Conformance Tests |
|
Azure Pipelines successfully started running 2 pipeline(s). |
rayaisaiah
approved these changes
Sep 5, 2025
rbtr
approved these changes
Sep 5, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
sivakami-projects
pushed a commit
that referenced
this pull request
Oct 23, 2025
* chore: update to go1.24 Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> * chore: cleanup rebase * chore: regenerate crds * chore: address comments * chore: clean up go tool cover * chore: pre-review cleanup * revert: ipv6 image from azurelinux to base * chore: add back go-junit-report tool install * chore: clean up cni non-constant Errorf usage * chore: clean up cns non-constant Sprintf usage * chore: clean up npm non-constant Sprintf usage * chore: clean up test non-constant Errorf usage * chore: cleanup windows NPM * chore: generate bpf-lib(s) for block-iptables in signed UTs * chore: cleanup rebase --------- Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> Co-authored-by: Evan Baker <rbtr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Takes on intent from #3467 and rebases it with new changes, notably
make dockerfileswhich leveragesrenderkitAdditionally:
go tools -modfile=tools.go.mod controller-gen ...make regenerate-crdto matchmake dockerfilesinteraction with GH workflow*printfusages - https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/printf#hdr-ExamplesIssue Fixed:
Requirements:
Notes: