Setup SNAT Configuration Based on Azure Host Support #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaer-tsun
force-pushed
the
configureSnatOnHost
branch
5 times, most recently
from
f90ee37 to
4ace0a3
Compare
tamilmani1989
requested changes
Sep 30, 2019
Member
tamilmani1989
left a comment
tamilmani1989
left a comment
There was a problem hiding this comment.
unit tests are missing.
jaer-tsun
force-pushed
the
configureSnatOnHost
branch
from
d03e72c to
dbf83ed
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jaer-tsun
force-pushed
the
configureSnatOnHost
branch
2 times, most recently
from
49a7ee1 to
70ffe52
Compare
jaer-tsun
force-pushed
the
configureSnatOnHost
branch
from
cd8e5be to
779622e
Compare
jaer-tsun
force-pushed
the
configureSnatOnHost
branch
from
266efc2 to
18ce2de
Compare
tamilmani1989
requested changes
Oct 21, 2019
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jaer-tsun
force-pushed
the
configureSnatOnHost
branch
6 times, most recently
from
a634e1d to
df3ed5b
Compare
jaer-tsun
changed the title
jaer-tsun
changed the title
jaer-tsun
force-pushed
the
configureSnatOnHost
branch
from
df3ed5b to
9a6b604
Compare
jaer-tsun
force-pushed
the
configureSnatOnHost
branch
from
4de34f9 to
bf243f3
Compare
jaer-tsun
force-pushed
the
configureSnatOnHost
branch
from
bf243f3 to
62168c2
Compare
tamilmani1989
previously approved these changes
Nov 12, 2019
jaer-tsun
force-pushed
the
configureSnatOnHost
branch
from
62168c2 to
304d082
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tamilmani1989
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
CNI will now query for SNAT and DNS support from Azure Host.
In Linux, the features can be separately applied; but on Windows SNAT will only be disabled if both new features on the Host are supported.