NPM test fixes + Azure Pipelines #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* initial azure-pipeline config * remove cns restserver from ci * publish coverage report to pipelines * use default go version on runner
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
==========================================
+ Coverage 52.15% 52.29% +0.14%
==========================================
Files 28 28
Lines 4044 4044
==========================================
+ Hits 2109 2115 +6
+ Misses 1666 1654 -12
- Partials 269 275 +6
Continue to review full report at Codecov.
|
saiyan86
previously approved these changes
Sep 19, 2019
Contributor
|
/lgtm |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jaer-tsun
suggested changes
Sep 20, 2019
.pipelines/pipeline.yml
Outdated
| - bash: | | ||
| go get -v -t -d ./... | ||
| if [ -f Gopkg.toml ]; then |
network/network_linux.go
Outdated
| return err | ||
| var err error | ||
|
|
||
| if(extIf != nil && len(extIf.DNSInfo.Servers) > 0) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: