Publish/Unpublish Network Containers via CNS #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
=======================================
Coverage 52.66% 52.66%
=======================================
Files 28 28
Lines 4022 4022
=======================================
Hits 2118 2118
Misses 1631 1631
Partials 273 273Continue to review full report at Codecov.
|
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ninzavivek
suggested changes
Nov 6, 2019
ninzavivek
suggested changes
Nov 12, 2019
Contributor
ninzavivek
left a comment
ninzavivek
left a comment
There was a problem hiding this comment.
Please close on whether it is ok to use nm agent url here or not?
ninzavivek
suggested changes
Nov 12, 2019
Contributor
|
Contributor
|
it looks like you are anyway handling it. |
ninzavivek
reviewed
Nov 12, 2019
ninzavivek
suggested changes
Nov 12, 2019
Member
Author
|
Reopening the PR which looks like was closed accidentally |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tamilmani1989
pushed a commit
to tamilmani1989/azure-container-networking
that referenced
this pull request
Jun 20, 2021
This change supports publishing/unpublishing NC via CNS. If the DNC config exposes the CNS connection URLs for publish and unpublish, DNC will make CNS call and have CNS publish and unpublish the NC. Failure to establish HTTP connection means the worker node may be deallocated. In such case DNC will publish/unpublish the NC from the node where DNC is running. Here is the CNS change in Azure Container Networking github repo: Azure#430 Before publishing / unpublishing the NC, CNS needs to make sure it joins the vnet to which the NC belongs to. PR URL: https://msazure.visualstudio.com/DefaultCollection/One/_git/Networking-Aquarius/pullrequest/2221382 Related work items: #5682508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose 2 APIs to publish and unpublish network containers from CNS.
a. PublishNetworkContainer
b. UnpublishNetworkContainer
DNC calls CNS to publish and unpublish the network containers.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: