-
Notifications
You must be signed in to change notification settings - Fork 260
Publish/Unpublish Network Containers via CNS #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5f4d1d7
initial code change to validate
ashvindeodhar 229d375
WIP-10-30-1
ashvindeodhar 52d38f3
WIP-10-31-1
ashvindeodhar e4786d2
WIP-10-31-2
ashvindeodhar 729e211
WIP-10-31-3
ashvindeodhar b951153
Fix the variable name
ashvindeodhar 8572fa2
WIP-11-04-1
ashvindeodhar d1a5f35
Address review comments
ashvindeodhar dd6f2fb
Add tests for new APIs
ashvindeodhar b151dd2
Add dummy URLs
ashvindeodhar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| package nmagentclient | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "encoding/json" | ||
| "net/http" | ||
|
|
||
| "github.com/Azure/azure-container-networking/common" | ||
| "github.com/Azure/azure-container-networking/log" | ||
| ) | ||
|
|
||
| // JoinNetwork joins the given network | ||
| func JoinNetwork( | ||
| networkID string, | ||
| joinNetworkURL string) (*http.Response, error) { | ||
| log.Printf("[NMAgentClient] JoinNetwork: %s", networkID) | ||
|
|
||
| // Empty body is required as wireserver cannot handle a post without the body. | ||
| var body bytes.Buffer | ||
| json.NewEncoder(&body).Encode("") | ||
| response, err := common.GetHttpClient().Post(joinNetworkURL, "application/json", &body) | ||
|
|
||
| if err == nil && response.StatusCode == http.StatusOK { | ||
| defer response.Body.Close() | ||
| } | ||
|
|
||
| log.Printf("[NMAgentClient][Response] Join network: %s. Response: %+v. Error: %v", | ||
| networkID, response, err) | ||
|
|
||
| return response, err | ||
| } | ||
|
|
||
| // PublishNetworkContainer publishes given network container | ||
| func PublishNetworkContainer( | ||
| networkContainerID string, | ||
| createNetworkContainerURL string, | ||
| requestBodyData []byte) (*http.Response, error) { | ||
| log.Printf("[NMAgentClient] PublishNetworkContainer NC: %s", networkContainerID) | ||
|
|
||
| requestBody := bytes.NewBuffer(requestBodyData) | ||
| response, err := common.GetHttpClient().Post(createNetworkContainerURL, "application/json", requestBody) | ||
|
|
||
| log.Printf("[NMAgentClient][Response] Publish NC: %s. Response: %+v. Error: %v", | ||
| networkContainerID, response, err) | ||
|
|
||
| return response, err | ||
| } | ||
|
|
||
| // UnpublishNetworkContainer unpublishes given network container | ||
| func UnpublishNetworkContainer( | ||
| networkContainerID string, | ||
| deleteNetworkContainerURL string) (*http.Response, error) { | ||
| log.Printf("[NMAgentClient] UnpublishNetworkContainer NC: %s", networkContainerID) | ||
|
|
||
| // Empty body is required as wireserver cannot handle a post without the body. | ||
| var body bytes.Buffer | ||
| json.NewEncoder(&body).Encode("") | ||
| response, err := common.GetHttpClient().Post(deleteNetworkContainerURL, "application/json", &body) | ||
|
|
||
| log.Printf("[NMAgentClient][Response] Unpublish NC: %s. Response: %+v. Error: %v", | ||
| networkContainerID, response, err) | ||
|
|
||
| return response, err | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.