-
Notifications
You must be signed in to change notification settings - Fork 260
Added config option for disabling iptable lock #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
==========================================
- Coverage 52.74% 52.71% -0.03%
==========================================
Files 28 28
Lines 4224 4215 -9
==========================================
- Hits 2228 2222 -6
+ Misses 1724 1723 -1
+ Partials 272 270 -2
Continue to review full report at Codecov.
|
chandanAggarwal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
ninzavivek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, we should update the conflist also. But it is upto you. I understand that it is workaround for short time, but change looks incomplete.
By default iptable lock is enabled. Even if we specify this in conflist, they have to manually flip the flag before rollout. I don't want to expose this to user to disable it unless there is a need. |
* added config option for disabling iptable lock * added log for iptable and ebtable version * moved logging dependency package details to platform specific file
* added config option for disabling iptable lock * added log for iptable and ebtable version * moved logging dependency package details to platform specific file
* added config option for disabling iptable lock * added log for iptable and ebtable version * moved logging dependency package details to platform specific file
What this PR does / why we need it:
Added config option for disabling iptable lock. By default, iptable lock is enabled. If users want to disable iptable lock, they have to set disableIPTableLock field to true in conflist.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: