Skip to content

Conversation

@tamilmani1989
Copy link
Member

What this PR does / why we need it:
Added config option for disabling iptable lock. By default, iptable lock is enabled. If users want to disable iptable lock, they have to set disableIPTableLock field to true in conflist.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #470 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage   52.74%   52.71%   -0.03%     
==========================================
  Files          28       28              
  Lines        4224     4215       -9     
==========================================
- Hits         2228     2222       -6     
+ Misses       1724     1723       -1     
+ Partials      272      270       -2
Impacted Files Coverage Δ
npm/translatePolicy.go 80.41% <0%> (-0.12%) ⬇️
npm/iptm/iptm.go 59.6% <0%> (+0.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94759f5...630531c. Read the comment docs.

Copy link

@chandanAggarwal chandanAggarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tamilmani1989 tamilmani1989 merged commit 5fb1d7f into Azure:master Jan 4, 2020
Copy link
Contributor

@ninzavivek ninzavivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, we should update the conflist also. But it is upto you. I understand that it is workaround for short time, but change looks incomplete.

@tamilmani1989
Copy link
Member Author

In my opinion, we should update the conflist also. But it is upto you. I understand that it is workaround for short time, but change looks incomplete.

By default iptable lock is enabled. Even if we specify this in conflist, they have to manually flip the flag before rollout. I don't want to expose this to user to disable it unless there is a need.

jaer-tsun referenced this pull request in jaer-tsun/azure-container-networking Jan 6, 2020
* added config option for disabling iptable lock

* added log for iptable and ebtable version

* moved logging dependency package details to platform specific file
jaer-tsun referenced this pull request in jaer-tsun/azure-container-networking Jan 6, 2020
* added config option for disabling iptable lock

* added log for iptable and ebtable version

* moved logging dependency package details to platform specific file
ashutoshishere04 pushed a commit to ashutoshishere04/azure-container-networking that referenced this pull request Jan 23, 2020
* added config option for disabling iptable lock

* added log for iptable and ebtable version

* moved logging dependency package details to platform specific file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants