Add AI Events and CNS NC Snapshots. #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashvindeodhar
previously approved these changes
Feb 12, 2020
tamilmani1989
requested changes
Feb 13, 2020
cns/restserver/restserver.go
Outdated
| logger.Printf("[Azure CNS] Listening.") | ||
|
|
||
| // Setup to emit snapshot periodically. | ||
| go service.sendNCSnapShotPeriodically(ncSnapshotIntervalInMinutes) |
Member
There was a problem hiding this comment.
should we call this if disableAll (disabletelemetry) is set?
tamilmani1989
requested changes
Feb 13, 2020
| // HTTPService describes the min API interface that every service should have. | ||
| type HTTPService interface { | ||
| common.ServiceAPI | ||
| SendNCSnapShotPeriodically(int, chan bool) |
Member
There was a problem hiding this comment.
why this has to be part of this structure?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: