Request controller for CNS #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #583 +/- ##
==========================================
+ Coverage 38.05% 39.88% +1.83%
==========================================
Files 41 43 +2
Lines 4904 4583 -321
==========================================
- Hits 1866 1828 -38
+ Misses 2783 2502 -281
+ Partials 255 253 -2 |
pjohnst5
changed the title
… in reconcile loop, ignoring spec updates in reconcil loop. Also adding ability for updating CRD spec through k8sRequestController methods
pjohnst5
changed the title
…iles to be less folder-y
paulgmiller
reviewed
Jun 24, 2020
paulgmiller
reviewed
Jun 24, 2020
paulgmiller
reviewed
Jun 24, 2020
paulgmiller
reviewed
Jun 24, 2020
paulgmiller
reviewed
Jun 24, 2020
cns/requestcontroller/kubernetes/nodenetworkconfigreconciler.go
Outdated
Show resolved
Hide resolved
paulgmiller
previously approved these changes
Jun 24, 2020
paulgmiller
reviewed
Jun 24, 2020
paulgmiller
reviewed
Jun 24, 2020
cns/requestcontroller/kubernetes/nodenetworkconfigreconciler.go
Outdated
Show resolved
Hide resolved
paulgmiller
reviewed
Jun 24, 2020
paulgmiller
reviewed
Jun 24, 2020
thatmattlong
requested changes
Jul 1, 2020
Collaborator
thatmattlong
left a comment
thatmattlong
left a comment
There was a problem hiding this comment.
Requested some changes. The main one being I think the CNSClient interface and implementation should not be part of the requestcontroller package, and instead should live in cns or a new package cns/client
thatmattlong
approved these changes
Jul 2, 2020
Collaborator
thatmattlong
left a comment
thatmattlong
left a comment
There was a problem hiding this comment.
There is one comment above for a type definition that I don't believe is being used anywhere. However, since that doesn't affect functionality, I'm approving these changes. If you remove that, I will re-approve.
pjohnst5
added a commit
to pjohnst5/azure-container-networking
that referenced
this pull request
Jul 9, 2020
* NewRequestController and StartRequestController * Making Start Manager in go routine * Lookup HOSTNAME env var * Adding cnsipaminterface.go * Created requestController interface and implemented updating CRD * fix windows 1903 test apimodel.json (Azure#585) * Avoiding redundant calls into cns by only watching for status updates in reconcile loop, ignoring spec updates in reconcil loop. Also adding ability for updating CRD spec through k8sRequestController methods * fixing comments * Cleaned up code and added more comments * Made client interface for testing purposes and changed structure of files to be less folder-y * Addressed comments from Paul Miller and Wei * Beginning unit tests * Finished unit tests * Fixing pipeline issues * found issue, fixed HOSTNAME environment variable dependency * review changes requested * more review changes * Addressed changes from yesterday's review * Changing makefile line to run correct package * Addressed Matt Long's suggestions Co-authored-by: Mathew Merrick <matmerr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
First iteration of CNS Request Controller for the AKS on Swift scenario
with an example of how to call the methods in cns/examplerequestcontroller/example/main.go