Set Windows 1903 e2e apimodel to latest #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
=======================================
Coverage 52.64% 52.64%
=======================================
Files 23 23
Lines 2857 2857
=======================================
Hits 1504 1504
Misses 1079 1079
Partials 274 274 |
pjohnst5
pushed a commit
to pjohnst5/azure-container-networking
that referenced
this pull request
Jun 22, 2020
pjohnst5
added a commit
that referenced
this pull request
Jul 2, 2020
* NewRequestController and StartRequestController * Making Start Manager in go routine * Lookup HOSTNAME env var * Adding cnsipaminterface.go * Created requestController interface and implemented updating CRD * fix windows 1903 test apimodel.json (#585) * Avoiding redundant calls into cns by only watching for status updates in reconcile loop, ignoring spec updates in reconcil loop. Also adding ability for updating CRD spec through k8sRequestController methods * fixing comments * Cleaned up code and added more comments * Made client interface for testing purposes and changed structure of files to be less folder-y * Addressed comments from Paul Miller and Wei * Beginning unit tests * Finished unit tests * Fixing pipeline issues * found issue, fixed HOSTNAME environment variable dependency * review changes requested * more review changes * Addressed changes from yesterday's review * Changing makefile line to run correct package * Addressed Matt Long's suggestions Co-authored-by: Mathew Merrick <matmerr@users.noreply.github.com>
pjohnst5
added a commit
to pjohnst5/azure-container-networking
that referenced
this pull request
Jul 9, 2020
* NewRequestController and StartRequestController * Making Start Manager in go routine * Lookup HOSTNAME env var * Adding cnsipaminterface.go * Created requestController interface and implemented updating CRD * fix windows 1903 test apimodel.json (Azure#585) * Avoiding redundant calls into cns by only watching for status updates in reconcile loop, ignoring spec updates in reconcil loop. Also adding ability for updating CRD spec through k8sRequestController methods * fixing comments * Cleaned up code and added more comments * Made client interface for testing purposes and changed structure of files to be less folder-y * Addressed comments from Paul Miller and Wei * Beginning unit tests * Finished unit tests * Fixing pipeline issues * found issue, fixed HOSTNAME environment variable dependency * review changes requested * more review changes * Addressed changes from yesterday's review * Changing makefile line to run correct package * Addressed Matt Long's suggestions Co-authored-by: Mathew Merrick <matmerr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set test vm image tag to be latest to keep up to date.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: