Fix NATing on *COW (HnsV2) Scenarios #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninzavivek
suggested changes
Jun 29, 2020
jaer-tsun
force-pushed
the
fixHnsV2Nat
branch
2 times, most recently
from
93a050d to
909dcc9
Compare
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
==========================================
- Coverage 38.63% 37.44% -1.19%
==========================================
Files 48 47 -1
Lines 5371 5215 -156
==========================================
- Hits 2075 1953 -122
+ Misses 3022 3000 -22
+ Partials 274 262 -12 |
…ario or if enableSnatForDns is true.
jaer-tsun
force-pushed
the
fixHnsV2Nat
branch
2 times, most recently
from
86c0a8f to
1d8727c
Compare
ninzavivek
suggested changes
Jul 15, 2020
ninzavivek
suggested changes
Jul 15, 2020
jaer-tsun
force-pushed
the
fixHnsV2Nat
branch
2 times, most recently
from
8fe122e to
7cff596
Compare
ninzavivek
approved these changes
Jul 15, 2020
neaggarwMS
pushed a commit
to neaggarwMS/azure-container-networking
that referenced
this pull request
Nov 13, 2020
* For HnsV2 we will only add outbound nat policy for single tenant scenario or if enableSnatForDns is true. * adding comments to detail results of determineSnat func Co-authored-by: Jaeryn <tsun.chu@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
For HnsV2 we will only add outbound nat policy for single tenant scenario or if enableSnatForDns is true.
Notes: