Changes for caching pod ip #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
==========================================
+ Coverage 39.88% 40.08% +0.20%
==========================================
Files 42 42
Lines 4586 4595 +9
==========================================
+ Hits 1829 1842 +13
+ Misses 2502 2500 -2
+ Partials 255 253 -2 |
csfmomo
reviewed
Jul 2, 2020
neaggarwMS
force-pushed
the
npm_handle_podupdates
branch
from
4375a35 to
4fb531f
Compare
neaggarwMS
force-pushed
the
npm_handle_podupdates
branch
from
4fb531f to
6253ad8
Compare
csfmomo
reviewed
Jul 9, 2020
npm/ipsm/ipsm.go
Outdated
| } | ||
|
|
||
| // Now cleanup the cache | ||
| if _, exists := ipsMgr.setMap[setName].elements[ip]; exists { |
Contributor
There was a problem hiding this comment.
nit pick, I think this condition check has already been done in line 285, we can go ahead and cleanup the cache.
csfmomo
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache the PodIp which is added in the ipset so that it gets cleaned up deterministically as Pod DeleteEvent callback is asynchronous.
In case Pod DeleteEvent is received after ip has been reassigning to another POD deployed in the same namespace, then there wont be any ipset change.