Skip to content

Conversation

@csfmomo
Copy link
Contributor

@csfmomo csfmomo commented Jul 8, 2020

fix: add logic to handle different order between network policy peers

Reason for Change:
Different order between network policy peers should not influence the iptable and ipset finally generated. The rule peers including namespace selector, pod selector, cidr rules.

Issue Fixed:
Different order between network policy peer will produce same network policy result.

Requirements:

@csfmomo csfmomo requested review from jaer-tsun and matmerr July 8, 2020 04:21
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #604 into master will decrease coverage by 1.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
- Coverage   39.40%   37.90%   -1.51%     
==========================================
  Files          47       46       -1     
  Lines        5177     5021     -156     
==========================================
- Hits         2040     1903     -137     
+ Misses       2870     2859      -11     
+ Partials      267      259       -8     

Copy link
Contributor

@jaer-tsun jaer-tsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@csfmomo csfmomo merged commit 14e8a98 into master Jul 8, 2020
@csfmomo csfmomo deleted the order branch July 8, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants