-
Notifications
You must be signed in to change notification settings - Fork 260
Implement ReconcileNCState #626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #626 +/- ##
==========================================
- Coverage 42.10% 42.08% -0.03%
==========================================
Files 72 72
Lines 10207 10243 +36
==========================================
+ Hits 4298 4311 +13
- Misses 5435 5453 +18
- Partials 474 479 +5 |
pjohnst5
reviewed
Jul 24, 2020
f653e7d to
c1fde40
Compare
c1fde40 to
d9e6a2f
Compare
pjohnst5
requested changes
Jul 27, 2020
d9e6a2f to
5d22b55
Compare
pjohnst5
requested changes
Jul 27, 2020
pjohnst5
approved these changes
Jul 27, 2020
Contributor
pjohnst5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
neaggarwMS
added a commit
to neaggarwMS/azure-container-networking
that referenced
this pull request
Nov 13, 2020
* Implement ReconcileNCState api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Init/Reconcile NC state to save NC configuration and save in memory state for Pods which are already allocated with NC's secondary ips.