feat: include subnet address space in CRD #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: removes `Netmask` from NNC Status because it is now redundant
neaggarwMS
approved these changes
Aug 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
=======================================
Coverage 42.02% 42.02%
=======================================
Files 71 71
Lines 10271 10271
=======================================
Hits 4316 4316
Misses 5477 5477
Partials 478 478 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
neaggarwMS
pushed a commit
to neaggarwMS/azure-container-networking
that referenced
this pull request
Nov 13, 2020
BREAKING CHANGE: removes `Netmask` from NNC Status because it is now redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: include subnet address space in CRD
BREAKING CHANGE: removes
Netmaskfrom NNC Status because it is now redundantReason for Change:
Adds subnet address space to CRD status
Requirements:
Notes: