Add prefixlength from SubnetAddressRange #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ramiro-gamarra
left a comment
ramiro-gamarra
left a comment
There was a problem hiding this comment.
Just a few comments/questions
neaggarwMS
force-pushed
the
cns_persistsubnetprefixpath
branch
from
89efbc6 to
3d1fff9
Compare
Codecov Report
@@ Coverage Diff @@
## master #651 +/- ##
==========================================
+ Coverage 42.01% 42.19% +0.17%
==========================================
Files 71 71
Lines 10266 10270 +4
==========================================
+ Hits 4313 4333 +20
+ Misses 5476 5464 -12
+ Partials 477 473 -4 |
ramiro-gamarra
approved these changes
Aug 14, 2020
neaggarwMS
added a commit
to neaggarwMS/azure-container-networking
that referenced
this pull request
Nov 13, 2020
* Add prefixlength from SubnetAddressRange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persist the prefix length of PrimaryIPConfiguration from SubnetAddressRange. Note, since SecondaryIPs are also allocated form same range, no need to persist the length with every secondary ip. That will be populated from primaryIP while passing info to CNI