Add error log and metrics to AI telemetry. #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd metrics is in another go routine.
Codecov Report
@@ Coverage Diff @@
## master #656 +/- ##
==========================================
- Coverage 42.10% 42.05% -0.05%
==========================================
Files 71 72 +1
Lines 10270 10350 +80
==========================================
+ Hits 4324 4353 +29
- Misses 5471 5524 +53
+ Partials 475 473 -2 |
matmerr
requested changes
Aug 19, 2020
neaggarwMS
pushed a commit
to neaggarwMS/azure-container-networking
that referenced
this pull request
Nov 13, 2020
* Accelerate metrics report from every 30 mins to every 5 mins. * Add errCountTest metric. * Refactor SendAiMetrics. AI initialization is in main routine while send metrics is in another go routine. * Add aiMetadata config. * Add SendErrorMetrics function in ai utils. * Going to push error log to AI telemetry. * Add error log to AI telemetry. * Change error message format. * Add error log and metrics to AI telemetry. * Remove unnecessary const. * Change heartbeat back to every 30 mins. * Seperate send log from SendErrorMetric function for better reuse. * Change a unit test set name to avoid kernel conflict. * Address comments. Make error log and metrics sending more generic. * Fix typo. * Fix indentation. * Fix AI initialize issue. * Remove unnecessary log. * Use break in if condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add error log and metrics to AI telemetry.
chore: Maintenance 🔧
style: Code Style 🎶
Notes: