Bring Goldpinger tests to ACN #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ramiro Gamarra <ragamarr@microsoft.com>
| operator: In | ||
| values: | ||
| - goldpinger | ||
| topologyKey: "kubernetes.io/hostname" |
Contributor
There was a problem hiding this comment.
One little thing is that topology key must be under pod affinity term. I have an internal patch to this that hasn't been merged yet.
ramiro-gamarra
previously approved these changes
Oct 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
==========================================
- Coverage 38.84% 38.63% -0.22%
==========================================
Files 79 79
Lines 10471 10471
==========================================
- Hits 4067 4045 -22
- Misses 5912 5935 +23
+ Partials 492 491 -1 |
ramiro-gamarra
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Ramiro Gamarra ragamarr@microsoft.com
Reason for Change:
Use the goldpinger framework setup by @ramiro-gamarra in the ACN pipeline
Issue Fixed:
Requirements:
Notes: