Skip to content

Conversation

@csfmomo
Copy link
Contributor

@csfmomo csfmomo commented Dec 12, 2020

Improvement: Ensure pending programming IPs will be released first when scale down.
Reason for Change:
When scale down, we want to ensure pending programming IPs can be released before available IPs to improve performance. Pending programming IPs need to check programmed NC version before available. Release pending programming IPs will save one step.

Issue Fixed:
Improve performance.

@csfmomo csfmomo changed the title Ensure pending programming IPs will be released first when scale down. Ensure pending programming IPs will be released before available IPs when scale down. Dec 12, 2020
@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #750 (e8e193e) into master (98f838e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   41.36%   41.40%   +0.03%     
==========================================
  Files         142      142              
  Lines       13472    13479       +7     
==========================================
+ Hits         5573     5581       +8     
+ Misses       7199     7198       -1     
  Partials      700      700              

@csfmomo csfmomo force-pushed the releasePendingFirst branch from 2c852af to 3a98514 Compare December 14, 2020 06:15
Copy link
Contributor

@ramiro-gamarra ramiro-gamarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

@csfmomo csfmomo force-pushed the releasePendingFirst branch from e17757f to bb7fd5a Compare January 12, 2021 01:52
@csfmomo csfmomo force-pushed the releasePendingFirst branch from bb7fd5a to 7a929ec Compare January 12, 2021 19:26
@csfmomo csfmomo force-pushed the releasePendingFirst branch from 7a929ec to 02c3d8e Compare January 12, 2021 21:33
@csfmomo csfmomo requested a review from neaggarwMS January 12, 2021 22:58
@csfmomo csfmomo force-pushed the releasePendingFirst branch from 02c3d8e to e8e193e Compare January 14, 2021 21:10
@csfmomo csfmomo dismissed neaggarwMS’s stale review January 15, 2021 07:17

Addressed feedback so merged.

Copy link
Contributor

@ramiro-gamarra ramiro-gamarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@csfmomo csfmomo merged commit 327b0b6 into Azure:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants