-
Notifications
You must be signed in to change notification settings - Fork 260
Ensure pending programming IPs will be released before available IPs when scale down. #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+125
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #750 +/- ##
==========================================
+ Coverage 41.36% 41.40% +0.03%
==========================================
Files 142 142
Lines 13472 13479 +7
==========================================
+ Hits 5573 5581 +8
+ Misses 7199 7198 -1
Partials 700 700 |
2c852af to
3a98514
Compare
neaggarwMS
previously requested changes
Jan 11, 2021
Contributor
ramiro-gamarra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
e17757f to
bb7fd5a
Compare
bb7fd5a to
7a929ec
Compare
7a929ec to
02c3d8e
Compare
02c3d8e to
e8e193e
Compare
ramiro-gamarra
approved these changes
Jan 15, 2021
Contributor
ramiro-gamarra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement: Ensure pending programming IPs will be released first when scale down.
Reason for Change:
When scale down, we want to ensure pending programming IPs can be released before available IPs to improve performance. Pending programming IPs need to check programmed NC version before available. Release pending programming IPs will save one step.
Issue Fixed:
Improve performance.
perf: Performance Improvements 🚀