Skip to content

Conversation

@pjohnst5
Copy link
Contributor

@pjohnst5 pjohnst5 commented Dec 18, 2020

Reason for Change:
Cross-platform makefile capabilities, to allow the possibility of running make targets on windows

Also cleaning up the Makefile and getting rid of some unused scripts

@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #758 (026871d) into master (53e45c8) will decrease coverage by 3.03%.
The diff coverage is n/a.

❗ Current head 026871d differs from pull request most recent head bab2cae. Consider uploading reports for the commit bab2cae to get more accurate results

@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
- Coverage   44.53%   41.49%   -3.04%     
==========================================
  Files         158      141      -17     
  Lines       27905    13461   -14444     
==========================================
- Hits        12428     5586    -6842     
+ Misses      14076     7182    -6894     
+ Partials     1401      693     -708     

@pjohnst5 pjohnst5 force-pushed the makefile-windows branch 3 times, most recently from 4590e5e to f4e5af0 Compare December 19, 2020 01:55
@pjohnst5 pjohnst5 marked this pull request as ready for review September 17, 2021 16:20
rbtr
rbtr previously approved these changes Sep 17, 2021
@pjohnst5
Copy link
Contributor Author

Had to fix something, I wrote a specific clause for windows platforms, and set the EXT variable there, but that EXT variable should only be set if the GOOS is windows

rbtr
rbtr previously approved these changes Sep 17, 2021
@pjohnst5
Copy link
Contributor Author

Something's wrong with this (zipping up windows files is corrupted) working on it

@pjohnst5 pjohnst5 merged commit 43d1d46 into Azure:master Sep 17, 2021
@pjohnst5 pjohnst5 deleted the makefile-windows branch September 17, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants