Skip to content

Conversation

@ramiro-gamarra
Copy link
Contributor

Reason for Change:

Log rotation does not respect configured target, causing it to always only log to file after initial rotation. This breaks stdout logging if enabled, once the first rotation takes place.

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #797 (be16450) into master (6586840) will increase coverage by 4.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
+ Coverage   37.88%   41.95%   +4.07%     
==========================================
  Files         142      142              
  Lines       15741    13952    -1789     
==========================================
- Hits         5963     5854     -109     
+ Misses       9043     7363    -1680     
  Partials      735      735              

@matmerr
Copy link
Member

matmerr commented Feb 22, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@neaggarwMS neaggarwMS merged commit 685cf90 into Azure:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants