Skip to content

Remove Log noise from ipam pool monitor #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2021
Merged

Remove Log noise from ipam pool monitor #798

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
024dca7
Remove Log noise from ipam pool monitor
neaggarwMS Feb 22, 2021
1827d20
incorporate feedback
neaggarwMS Feb 22, 2021
17ee70a
Fix logging string
neaggarwMS Feb 22, 2021
0e99c02
build fix
neaggarwMS Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cns/ipampoolmonitor/ipampoolmonitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,29 +70,29 @@ func (pm *CNSIPAMPoolMonitor) Reconcile() error {
availableIPConfigCount := len(pm.cns.GetAvailableIPConfigs()) // TODO: add pending allocation count to real cns
freeIPConfigCount := pm.cachedNNC.Spec.RequestedIPCount - int64(allocatedPodIPCount)

logger.Printf("[ipam-pool-monitor] Checking pool for resize, Pool Size: %v, Goal Size: %v, BatchSize: %v, MinFree: %v, MaxFree:%v, Allocated: %v, Available: %v, Pending Release: %v, Free: %v, Pending Program: %v",
msg := fmt.Sprintf("Pool Size: %v, Goal Size: %v, BatchSize: %v, MinFree: %v, MaxFree:%v, Allocated: %v, Available: %v, Pending Release: %v, Free: %v, Pending Program: %v",
cnsPodIPConfigCount, pm.cachedNNC.Spec.RequestedIPCount, pm.scalarUnits.BatchSize, pm.MinimumFreeIps, pm.MaximumFreeIps, allocatedPodIPCount, availableIPConfigCount, pendingReleaseIPCount, freeIPConfigCount, pendingProgramCount)

switch {
// pod count is increasing
case freeIPConfigCount < pm.MinimumFreeIps:
logger.Printf("[ipam-pool-monitor] Increasing pool size...")
logger.Printf("[ipam-pool-monitor] Increasing pool size...%s ", msg)
return pm.increasePoolSize()

// pod count is decreasing
case freeIPConfigCount > pm.MaximumFreeIps:
logger.Printf("[ipam-pool-monitor] Decreasing pool size...")
logger.Printf("[ipam-pool-monitor] Decreasing pool size...%s ", msg)
return pm.decreasePoolSize()

// CRD has reconciled CNS state, and target spec is now the same size as the state
// free to remove the IP's from the CRD
case pm.pendingRelease && int(pm.cachedNNC.Spec.RequestedIPCount) == cnsPodIPConfigCount:
logger.Printf("[ipam-pool-monitor] Removing Pending Release IP's from CRD...")
logger.Printf("[ipam-pool-monitor] Removing Pending Release IP's from CRD...%s ", msg)
return pm.cleanPendingRelease()

// no pods scheduled
case allocatedPodIPCount == 0:
logger.Printf("[ipam-pool-monitor] No pods scheduled")
logger.Printf("[ipam-pool-monitor] No pods scheduled, %s", msg)
return nil
}

Expand Down