Skip to content

[build] Makefile update to generate image tarballs in artifacts #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 25, 2021
Merged

[build] Makefile update to generate image tarballs in artifacts #804

merged 17 commits into from
Mar 25, 2021

Conversation

@matmerr
Copy link
Member

@matmerr matmerr commented Feb 25, 2021 •
edited by pjohnst5
Loading

Reason for Change:

  • Release process requires image tarballs, saving to separate directory instead of output.
  • Consolidating CNS docker file to just one

Issue Fixed:

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Feb 25, 2021 •
edited
Loading

Codecov Report

Merging #804 (4210484) into master (a0c36fe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #804   +/-   ##
=======================================
  Coverage   41.99%   41.99%           
=======================================
  Files         152      152           
  Lines       14486    14486           
=======================================
  Hits         6084     6084           
  Misses       7665     7665           
  Partials      737      737

@pjohnst5 pjohnst5 self-requested a review February 26, 2021 18:35
pjohnst5
pjohnst5 previously approved these changes Feb 26, 2021
View reviewed changes
Copy link
Contributor

@pjohnst5 pjohnst5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, I will wait for this to merge in before changing CNS's base to Alpine

@matmerr
Copy link
Member Author

matmerr commented Mar 2, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 2, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@matmerr
Copy link
Member Author

matmerr commented Mar 2, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 2, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@pjohnst5 pjohnst5 requested a review from thatmattlong March 25, 2021 20:15
@pjohnst5 pjohnst5 merged commit fe66f5b into Azure:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thatmattlong thatmattlong thatmattlong approved these changes

@pjohnst5 pjohnst5 pjohnst5 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matmerr @pjohnst5 @thatmattlong