Change version comparison from string to int and add more log in SyncHostNCVersion. #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
==========================================
- Coverage 42.23% 42.04% -0.19%
==========================================
Files 152 152
Lines 14335 14379 +44
==========================================
- Hits 6054 6046 -8
- Misses 7554 7596 +42
- Partials 727 737 +10 |
csfmomo
force-pushed
the
fixChannel
branch
2 times, most recently
from
1600635 to
5fcd7e0
Compare
csfmomo
changed the title
ramiro-gamarra
requested changes
Mar 17, 2021
Contributor
ramiro-gamarra
left a comment
ramiro-gamarra
left a comment
There was a problem hiding this comment.
A test should be added to the function that failed previously
cns/restserver/ipam.go
Outdated
| previousHostNCVersion := ncInfo.HostVersion | ||
| previousHostNCVersion, err := strconv.Atoi(ncInfo.HostVersion) | ||
| if err != nil { | ||
| logger.Printf("[MarkIpsAsAvailableUntransacted] Get int value from ncInfo.HostVersion %s failed for %v", ncInfo.HostVersion, err) |
Contributor
There was a problem hiding this comment.
nit: better to use colon than for
[MarkIpsAsAvailableUntransacted] Get int value from ncInfo.HostVersion %s failed: %v
also, if it fails, the rest of the block should not execute, since it would be acting on previousHostNCVersion being 0. Probably should continue here
… int to avoid bug when version 9 update to 10. 2. Add more log in SyncHostNCVersion. 3. Remove unnecessary check for MarkIpsAsAvailable. 4. Auto formatting.
ramiro-gamarra
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Change version comparison from string to int and as well as the following 3 improvements.
1. Add more log in SyncHostNCVersion.
2. Remove unnecessary check for MarkIpsAsAvailable.
3. Auto formatting.
Reason for Change:
Logs are not sufficient enough to debug.
Issue Fixed:
After these logs got added, it will unsure whether host version got updated.
In another word, after log got added, we are clear whether select sentence after channel got executed porperly.