[NPM] NameSpace resource controller changes #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakalapa
changed the title
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
==========================================
+ Coverage 41.60% 41.87% +0.26%
==========================================
Files 157 157
Lines 14973 15018 +45
==========================================
+ Hits 6230 6289 +59
+ Misses 7992 7969 -23
- Partials 751 760 +9 |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JungukCho
reviewed
Mar 30, 2021
JungukCho
reviewed
Mar 30, 2021
vakalapa
commented
Mar 30, 2021
vakalapa
commented
Mar 30, 2021
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JungukCho
suggested changes
Mar 31, 2021
| PodMap: make(map[string]*NpmPod), | ||
| RawNpMap: make(map[string]*networkingv1.NetworkPolicy), | ||
| ProcessedNpMap: make(map[string]*networkingv1.NetworkPolicy), | ||
| TelemetryEnabled: false, |
Contributor
There was a problem hiding this comment.
For NSController UT, do we need podMap, RawNpMap, ProcessNpMap, and TelemetryEnabled"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes includes adding workerqueue support for handling NameSpace resource shared informer events