feature: don't let CNS ask for more IPS than node limit #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
==========================================
+ Coverage 42.13% 42.24% +0.11%
==========================================
Files 158 158
Lines 15089 15123 +34
==========================================
+ Hits 6358 6389 +31
- Misses 7954 7956 +2
- Partials 777 778 +1 |
neaggarwMS
reviewed
Apr 6, 2021
neaggarwMS
reviewed
Apr 6, 2021
neaggarwMS
reviewed
Apr 6, 2021
neaggarwMS
reviewed
Apr 6, 2021
neaggarwMS
reviewed
Apr 6, 2021
matmerr
pushed a commit
to matmerr/azure-container-networking
that referenced
this pull request
Apr 21, 2021
* feature: CNS to honor MaxIPCount in CRD for scaling events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
CNS would ask for more IPS than the node limit, so making CNS stop asking once the node limit has been reached
Also ensures CNS asks for a multiple of the batch size on scale down after reaching the node limit