Skip to content

Conversation

@JungukCho
Copy link
Contributor

@JungukCho JungukCho commented May 3, 2021

Reason for Change:

This PR is to filter a pod in pod event handler functions when the pod has ipv6 address since NPM does not support ipv6 yet.
In addition, it also checks a valid ipv4 address format of the pod.

Issue Fixed:

Requirements:

Notes:
We need to revisit error code handling in ipsm.go and iptm.go.
One example is that ipsm caches the item even though invalid IPv4 or IPv6 address are inserted (returned error code is 1).
Further it causes controllers to process the rest of operations.
While this PR filters invalid IPv4 and IPv6 address in early stage to avoid the situation, we need to revisit all codes thoroughly.
We may need to use this code #840

vakalapa
vakalapa previously approved these changes May 5, 2021
@JungukCho JungukCho requested a review from matmerr May 5, 2021 18:23
@vakalapa vakalapa self-requested a review May 5, 2021 18:45
@JungukCho
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@JungukCho
Copy link
Contributor Author

I realized observed error message related to IPv6 is from network policy.
So, I need to update networkPolicyController.go or ipsm.go to handle the issue correctly.
I may create another PR to resolve it.

@JungukCho
Copy link
Contributor Author

Close now. I will link a new PR which will resolve the root cause of this issue (netpol with ipv6 cidr value) in this PR later.

@JungukCho JungukCho closed this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement npm Related to NPM.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants