[CNI] Update CNI to pass IP address on delete #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmerr
force-pushed
the
cnidelwithipaddress
branch
3 times, most recently
from
1cfa5ba to
a5cc182
Compare
matmerr
commented
May 28, 2021
neaggarwMS
requested changes
Jun 1, 2021
rbtr
previously approved these changes
Jun 1, 2021
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
comment and a question otherwise lgtm
cns/cnsclient/cnsclient.go
Outdated
| // ReleaseIPAddress calls releaseIPAddress on CNS | ||
| func (cnsClient *CNSClient) ReleaseIPAddress(orchestratorContext []byte) error { | ||
| // ReleaseIPAddress calls releaseIPAddress on CNS, ipaddress ex: (10.0.0.1) | ||
| func (cnsClient *CNSClient) ReleaseIPAddress(ipaddress string, orchestratorContext []byte) error { |
Collaborator
There was a problem hiding this comment.
would it be better to pass these around as net.IP and then string them just in time for use? we could error on parsing at ingest instead of at use if something weird comes in
Member
Author
There was a problem hiding this comment.
moved it a little bit forward to directly populate the request object to send to the client
matmerr
force-pushed
the
cnidelwithipaddress
branch
from
eda8be5 to
7ed04d6
Compare
neaggarwMS
previously approved these changes
Jun 1, 2021
matmerr
force-pushed
the
cnidelwithipaddress
branch
from
7ed04d6 to
901e839
Compare
rbtr
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
New CNI log line:
New CNS log line:
Issue Fixed:
#885
Requirements:
Notes: