Skip to content

Conversation

@matmerr
Copy link
Member

@matmerr matmerr commented Jun 4, 2021

Reason for Change:

Instead of CNS rehydrating from API server, CNS can use CNI to rehydrate from state stored on disk.

Issue Fixed:

Requirements:

Notes:

rbtr
rbtr previously requested changes Jun 7, 2021
Copy link
Collaborator

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confusing that the lint step didn't catch the error casing, because it does locally for me

@matmerr matmerr force-pushed the cnidumpstate branch 4 times, most recently from fb51b77 to 3c5fa3f Compare June 11, 2021 18:49
Copy link
Member

@neaggarwMS neaggarwMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@matmerr matmerr dismissed stale reviews from rbtr and tamilmani1989 June 11, 2021 20:44

resolved concerns, stale review

@matmerr matmerr merged commit b09ca83 into Azure:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants