chore: migrate from exit/err channels to context #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
force-pushed
the
rbtr/context
branch
4 times, most recently
from
9c396a7 to
b8d0e6a
Compare
thatmattlong
requested changes
Jun 16, 2021
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
neaggarwMS
reviewed
Jun 21, 2021
neaggarwMS
reviewed
Jun 21, 2021
rbtr
force-pushed
the
rbtr/context
branch
2 times, most recently
from
6e3c0c0 to
b97f731
Compare
thatmattlong
previously approved these changes
Jun 22, 2021
csfmomo
pushed a commit
that referenced
this pull request
Jun 25, 2021
* chore: migrate from exit/err channels to context Signed-off-by: Evan Baker <rbtr@users.noreply.github.com> * pass context instead of storing * rename controller packages * comment init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Evan Baker rbtr@users.noreply.github.com
Reason for Change:
Migrates from a variety of exit and err channels to a runtime context. In this PR, the root context is passed directly to the child contexts (since the previous exit channels where never closed independently, only when the parent scope was exiting), but this could serve as a basis to derive cancellable or timeout child contexts in the future.
Issue Fixed:
Requirements:
Notes: