fix: [CNI] handle getting endpoints when state file is empty #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmerr
force-pushed
the
cnifiledirectory
branch
2 times, most recently
from
4781851 to
40fc997
Compare
matmerr
changed the title
matmerr
force-pushed
the
cnifiledirectory
branch
from
40fc997 to
97991e8
Compare
tamilmani1989
requested changes
Jun 30, 2021
store/json.go
Outdated
|
|
||
| if len(b) == 0 { | ||
| log.Printf("Unable to read file %s, was empty", kvs.fileName) | ||
| return nil |
Member
There was a problem hiding this comment.
i would suggest return ErrEmptyFile and handle this in restore function (network/manager.go and ipam/manager.go) as like ErrKeyNotFound
Member
There was a problem hiding this comment.
@tamilmani1989 , this store file is also read by CNS to save CNS state, if are returning error then we need to handle it in there as well.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
When reconciling with CNI, it may be the case that CNI state hasn't been created yet. Don't block consumers of that state when empty.
Issue Fixed:
Requirements:
Notes: