[NPM] [bug] Adding sort in iptable comment for deterministic behavior in Flake UT #924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
reviewed
Jul 7, 2021
Collaborator
rbtr
left a comment
rbtr
left a comment
There was a problem hiding this comment.
lgtm with one question/change
npm/translatePolicy.go
Outdated
| } | ||
|
|
||
| sort.Strings(comments) | ||
| comment := strings.Join(comments, "-AND-") + "-AND-" |
Collaborator
There was a problem hiding this comment.
are you appending -AND- but then immediately chomping it off below when returning [:len - len("-AND-")]?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestAllowMultiplePodSelectors has a flake UT result due to ordering of ipset name in the comment. This PR fixes it