chore: typed response codes #954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
force-pushed
the
typed-response-code
branch
from
7ecd585 to
84af0cb
Compare
rbtr
force-pushed
the
typed-response-code
branch
3 times, most recently
from
3facbbf to
fd99c17
Compare
neaggarwMS
reviewed
Jul 28, 2021
neaggarwMS
reviewed
Jul 28, 2021
neaggarwMS
reviewed
Jul 28, 2021
tamilmani1989
previously requested changes
Jul 28, 2021
rbtr
force-pushed
the
typed-response-code
branch
from
fd99c17 to
325b2ec
Compare
thatmattlong
approved these changes
Aug 6, 2021
Collaborator
Author
|
failing test is unrelated and was introduced in #960 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Upgrade the response codes from raw int to a first-class
ResponseCodetype. Implicitly guarantees that the codes being returned are a known response code, since returns must be correctly typed to compile.Issue Fixed:
Requirements:
Notes: