fix: pass vlan id and encap type to CNS from CRD #960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feiskyer
reviewed
Aug 3, 2021
| // NOTE: json tags are required. Any new fields you add must have json tags for the fields to be serialized. | ||
| // Important: Run "make" to regenerate code after modifying this file | ||
|
|
||
| //MultiTenantInfo holds the encap type and id for the NC |
Member
There was a problem hiding this comment.
could you fix the lint failures?
feiskyer
reviewed
Aug 3, 2021
| PrimaryInterfaceIdentifier: nc.Status.PrimaryInterfaceIdentifier, | ||
| MultiTenancyInfo: cns.MultiTenancyInfo{ | ||
| EncapType: nc.Status.MultiTenantInfo.EncapType, | ||
| ID: int(nc.Status.MultiTenantInfo.ID), |
Member
There was a problem hiding this comment.
since MultiTenantInfo.ID is required for CNS, could we check its value in L109 and report an error if it is not set?
feiskyer
approved these changes
Aug 5, 2021
Collaborator
|
@feiskyer this has a legitimately broken test, please don't merge with failing checks |
3 tasks
Collaborator
Author
|
My fault, I said I had fixed the issues but didn't see this failing test, here is the PR to fix: #963 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Pass the vlan ID and encapsulation type to the CNS createNCRequest for multitenant CRD mode
Requirements: