[NPM] Print running NPM version in stdout. #958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace log with klog.
JungukCho
changed the title
Member
|
maybe with the cli tools we should add a |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
Author
That sounds useful. |
vakalapa
reviewed
Aug 4, 2021
|
|
||
| npMgr := npm.NewNetworkPolicyManager(clientset, factory, exec.New(), version) | ||
| metrics.CreateTelemetryHandle(npMgr.GetAppVersion(), npm.GetAIMetadata()) | ||
| metrics.CreateTelemetryHandle(version, npm.GetAIMetadata()) |
Contributor
There was a problem hiding this comment.
Can you fix this lint please, apart from that the PR looks good.
Contributor
Author
There was a problem hiding this comment.
As we agreed, it will come with another PR about metric.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR is to print running NPM version in stdout which can help diagnose errors or know tested version (e.g., which version is used for testing).
In addition, this PR replace log with klog for better stdout format in npm.go and main.go
Issue Fixed:
Requirements:
Notes: