Skip to content

Conversation

@rbtr
Copy link
Collaborator

@rbtr rbtr commented Aug 9, 2021

Reason for Change:

Finishes and closes #962.

There is a current bug in IPAM pool monitor where if a scale up happens right after scale down then we were accidently deleting the IpsNotInUse list in case Scale up Requested count is same as Total current ip count in CNS.

As a result DNC was not honoring the scale down as well not allocating new IPs because the existing secondary ip count matches the updated requested count.

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr requested review from neaggarwMS and thatmattlong August 9, 2021 17:55
@rbtr rbtr changed the title fix: hysteresis in ipampool scaling during rapid pool scaling fix: hysteresis in ipampool during rapid pool scaling Aug 9, 2021
thatmattlong
thatmattlong previously approved these changes Aug 9, 2021
@rbtr rbtr dismissed thatmattlong’s stale review August 9, 2021 22:02

needs more work

@rbtr rbtr force-pushed the fix/ipampool-scaling branch from 4adaf58 to ce4885c Compare August 9, 2021 23:12
@rbtr rbtr force-pushed the fix/ipampool-scaling branch from ce4885c to f8f4c66 Compare August 9, 2021 23:15
@rbtr rbtr merged commit 3bd237c into Azure:master Aug 10, 2021
@rbtr rbtr deleted the fix/ipampool-scaling branch August 10, 2021 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants