Fix CNS Scale Up/down fix to avoid cleanup pending ToBeDeleted ips #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatmattlong
reviewed
Aug 6, 2021
|
|
||
| // CNSToCRDSpec translates CNS's map of Ips to be released and requested ip count into a CRD Spec | ||
| func (pm *CNSIPAMPoolMonitor) createNNCSpecForCRD(resetNotInUseList bool) (nnc.NodeNetworkConfigSpec, error) { | ||
| func (pm *CNSIPAMPoolMonitor) createNNCSpecForCRD() (nnc.NodeNetworkConfigSpec, error) { |
Collaborator
There was a problem hiding this comment.
Can you change this function signature to remove the error: func (pm *CNSIPAMPoolMonitor) createNNCSpecForCRD() nnc.NodeNetworkConfigSpec { ... }?
thatmattlong
requested changes
Aug 6, 2021
Collaborator
thatmattlong
left a comment
thatmattlong
left a comment
There was a problem hiding this comment.
@neaggarwMS can you fix the linter errors?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a current bug in IPAM pool monitor where if a scale up happens right after scale down then we were accidently deleting the IpsNotInUse list in case Scale up Requested count is same as Total current ip count in CNS.
As a result DNC was not honoring the scale down as well not allocating new IPs because the existing secondary ip count matches the updated requested count.