chore: Add mock prefix so generated code is not counted against coverage #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmerr
force-pushed
the
mockmultitenanttests
branch
from
ff41ad3 to
2183c0a
Compare
Collaborator
|
to rename those mocks, you should update the makefile in that dir to write the new filename and rerun it, and can we suffix with |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
matmerr
force-pushed
the
mockmultitenanttests
branch
from
2183c0a to
b479823
Compare
neaggarwMS
requested changes
Sep 1, 2021
Makefile
Outdated
| test-all: | ||
| go test -tags "unit" -coverpkg=./... -v -race -covermode atomic -failfast -coverprofile=coverage.out ./... | ||
| test-all: | ||
| @$(eval CVPKG=`go list ./... | grep -v mock | tr '\n' ','`) |
Member
There was a problem hiding this comment.
isnt the package named "mockclients"
neaggarwMS
previously approved these changes
Sep 13, 2021
tamilmani1989
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: