Skip to content

Conversation

@rbtr
Copy link
Collaborator

@rbtr rbtr commented Sep 1, 2021

Reason for Change:

Correct gofumpt findings, automatically, by $ gofumpt -w -s .

Issue Fixed:

Requirements:

Notes:

@rbtr rbtr changed the title chore: appease the linter part 3/?, the big gofumpt chore: appease the linter (3/?), the big gofumpt Sep 1, 2021
@rbtr rbtr requested a review from vakalapa September 1, 2021 19:29
@rbtr
Copy link
Collaborator Author

rbtr commented Sep 1, 2021

@vakalapa adding you as reviewer because github says you most recently edited all these files 😛

Copy link
Contributor

@vakalapa vakalapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, almost all changes seem straight forward.

vakalapa
vakalapa previously approved these changes Sep 1, 2021
Copy link
Contributor

@vakalapa vakalapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@vakalapa vakalapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only 3 files got updated.

@rbtr
Copy link
Collaborator Author

rbtr commented Sep 2, 2021

bypassing lint check since it is just a big false positive

@rbtr rbtr merged commit 96bec09 into Azure:master Sep 2, 2021
@rbtr rbtr deleted the chore/gofumpt branch September 2, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants