-
Notifications
You must be signed in to change notification settings - Fork 260
Adding a build stage for arm64 cni #990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
rather than new build steps, could the existing build steps be updated to take a matrix of build args? it seems unlikely that this is the last GOOS or GOARCH change we will ever have to make, and that would:
|
|
Hi Evan, what would that look like? I like the idea, just don't really know what it would look like |
|
I think this could be as easy as adding a make target to the effect of make all-binaries-multiplatform GOOSES=linux,windows GOARCHES=arm64,amd64then that make target could iterate those arrays to build the matrix of build targets, and just call the existing make targets with update build args: all-binaries-multiplatform:
for goos in $(GOOSES):
for goarch in $(GOARCHES):
$(MAKE) all-binaries GOOS=$$goos GOARCH=$$goarchbut...in actual shell script😁 |
rbtr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking on discussed multiplatform change
|
Trying out the for loop way, where we pass in GOOS=linux,windows GOARCH=amd64,arm64 |
rbtr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multiplat target looks good 💯 just a couple cleanup things around it
rbtr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Reason for Change:
We need to build an ARM64 version of CNI too now.
Validation on an ARM64 machine:
And when I try running an amd64`cni binary on an arm64 machine, it fails