[NPM] refactor: npmcache json marshaling #993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JungukCho
requested review from
huntergregory,
matmerr,
neaggarwMS,
rbtr and
vakalapa
JungukCho
force-pushed
the
fix/npm-marshaling
branch
2 times, most recently
from
8265af9 to
6d058ed
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
rbtr
force-pushed
the
fix/npm-marshaling
branch
from
131e034 to
adc134a
Compare
JungukCho
force-pushed
the
fix/npm-marshaling
branch
from
b5da369 to
0947872
Compare
rbtr
requested changes
Sep 17, 2021
| @@ -0,0 +1,1579 @@ | |||
| { | |||
Collaborator
There was a problem hiding this comment.
instead of "testfiles", call test folders "testdata"
https://pkg.go.dev/cmd/go/internal/test
The go tool will ignore a directory named "testdata", making it available
to hold ancillary data needed by the tests.
rbtr
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Do a right way of encoding and decoding npmCache to achieve performance and json compatibility.
All credits to @rbtr to refactor codes.
Issue Fixed:
Requirements:
Notes: