[NPM] chore: NPM telemetry cleanup #999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JungukCho
requested review from
ashvindeodhar,
huntergregory,
jaer-tsun,
matmerr,
tamilmani1989 and
vakalapa
tamilmani1989
approved these changes
Sep 13, 2021
| version: npmVersion, | ||
| TelemetryEnabled: true, | ||
| k8sServerVersion: k8sServerVersion, | ||
| NodeName: os.Getenv("HOSTNAME"), |
Member
There was a problem hiding this comment.
can you also add this(nodeName) for cni future PR if not present
Member
There was a problem hiding this comment.
ignore.. AI wrapper package adds vm name
Contributor
Author
There was a problem hiding this comment.
@tamilmani1989 I guess you meant in CNIReport struct?
Member
There was a problem hiding this comment.
ignore my comment.. nodename will get added by default in AItelemetry package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Remove dead codes in NPM-related metrics from telemetry and NPM
Issue Fixed:
Requirements:
Notes: