Don't default necessary values to empty strings#1772
Merged
jongio merged 3 commits intoAzure:mainfrom Mar 22, 2023
pamelafox:container-app-empty
Merged
Don't default necessary values to empty strings#1772jongio merged 3 commits intoAzure:mainfrom pamelafox:container-app-empty
jongio merged 3 commits intoAzure:mainfrom
pamelafox:container-app-empty
Conversation
ghost
assigned
Member
Author
|
Made a couple more similar changes, done making changes now. |
Contributor
|
/azp run azure-dev - template - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run azure-dev - repoman |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: todo-csharp-cosmos-sqlRemote: azure-samples-stagingBranch: pr/1772You can initialize this project with: azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/1772View Changes | Compare Changes Project: todo-csharp-sql-swa-funcRemote: azure-samples-stagingBranch: pr/1772You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/1772View Changes | Compare Changes Project: todo-csharp-sqlRemote: azure-samples-stagingBranch: pr/1772You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql -b pr/1772View Changes | Compare Changes Project: todo-java-mongo-acaRemote: azure-samples-stagingBranch: pr/1772You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo-aca -b pr/1772View Changes | Compare Changes Project: todo-java-mongoRemote: azure-samples-stagingBranch: pr/1772You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo -b pr/1772View Changes | Compare Changes Project: todo-nodejs-mongo-acaRemote: azure-samples-stagingBranch: pr/1772You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/1772View Changes | Compare Changes Project: todo-nodejs-mongo-aksRemote: azure-samples-stagingBranch: pr/1772You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/1772View Changes | Compare Changes Project: todo-nodejs-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/1772You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/1772View Changes | Compare Changes Project: todo-nodejs-mongoRemote: azure-samples-stagingBranch: pr/1772You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo -b pr/1772View Changes | Compare Changes Project: todo-python-mongo-acaRemote: azure-samples-stagingBranch: pr/1772You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-aca -b pr/1772View Changes | Compare Changes Project: todo-python-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/1772You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/1772View Changes | Compare Changes Project: todo-python-mongoRemote: azure-samples-stagingBranch: pr/1772You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo -b pr/1772View Changes | Compare Changes |
Contributor
|
Some templates failed to deploy because of an unrelated issue. I investigated the errors and confirmed it was separate, provisioning actually succeeded in those cases, and for |
weikanglim
approved these changes
Mar 22, 2023
Contributor
|
/check-enforcer override |
Member
Author
|
thanks @weikanglim for checking the tests out! |
jongio
added a commit
that referenced
this pull request
Mar 25, 2026
…ibutes - Add telemetry to auth, config, env, hooks, templates, pipeline, monitor, show, infra commands - Add 16 new telemetry field constants for command-specific attributes - Fix user identity tracking with Anonymous account type fallback - Fix flaky TestStateCacheManager_TTL timing issue - Add audit documentation: feature matrix, schema, privacy checklist, audit process - Add telemetry field contract tests and CI coverage check Resolves #1772 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
added a commit
that referenced
this pull request
Mar 25, 2026
…ibutes - Add telemetry to auth, config, env, hooks, templates, pipeline, monitor, show, infra commands - Add 16 new telemetry field constants for command-specific attributes - Fix user identity tracking with Anonymous account type fallback - Fix flaky TestStateCacheManager_TTL timing issue - Add audit documentation: feature matrix, schema, privacy checklist, audit process - Add telemetry field contract tests and CI coverage check Resolves #1772 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
added a commit
that referenced
this pull request
Mar 25, 2026
…ibutes - Add telemetry to auth, config, env, hooks, templates, pipeline, monitor, show, infra commands - Add 16 new telemetry field constants for command-specific attributes - Fix user identity tracking with Anonymous account type fallback - Fix flaky TestStateCacheManager_TTL timing issue - Add audit documentation: feature matrix, schema, privacy checklist, audit process - Add telemetry field contract tests and CI coverage check Resolves #1772 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
added a commit
that referenced
this pull request
Mar 26, 2026
…ibutes - Add telemetry to auth, config, env, hooks, templates, pipeline, monitor, show, infra commands - Add 16 new telemetry field constants for command-specific attributes - Fix user identity tracking with Anonymous account type fallback - Fix flaky TestStateCacheManager_TTL timing issue - Add audit documentation: feature matrix, schema, privacy checklist, audit process - Add telemetry field contract tests and CI coverage check Resolves #1772 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The template analyzer pointed out this issue with container-app.bicep, that it sets the names to empty strings that are later used to define existing resources. You can't define an existing resource with an empty string, so that's not a valid default value for it. These values always need to be set, as far as I can see.