Skip to content

Don't default necessary values to empty strings #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jongio merged 3 commits into from
Mar 22, 2023
Merged

Don't default necessary values to empty strings #1772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2676131
Dont default necessary values to empty strings
pamelafox Mar 21, 2023
f116091
make same change to keyvault-access
pamelafox Mar 22, 2023
c5697d1
make same change in container-apps.bicep
pamelafox Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions templates/common/infra/bicep/core/host/container-app.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ param name string
param location string = resourceGroup().location
param tags object = {}

param containerAppsEnvironmentName string = ''
param containerAppsEnvironmentName string
param containerName string = 'main'
param containerRegistryName string = ''
param containerRegistryName string
param env array = []
param external bool = true
param imageName string
Expand Down
6 changes: 3 additions & 3 deletions templates/common/infra/bicep/core/host/container-apps.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ param name string
param location string = resourceGroup().location
param tags object = {}

param containerAppsEnvironmentName string = ''
param containerRegistryName string = ''
param logAnalyticsWorkspaceName string = ''
param containerAppsEnvironmentName string
param containerRegistryName string
param logAnalyticsWorkspaceName string

module containerAppsEnvironment 'container-apps-environment.bicep' = {
name: '${name}-container-apps-environment'
Expand Down
2 changes: 1 addition & 1 deletion templates/common/infra/bicep/core/security/keyvault-access.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
param name string = 'add'

param keyVaultName string = ''
param keyVaultName string
param permissions object = { secrets: [ 'get', 'list' ] }
param principalId string

Expand Down