Skip to content

fix: change AZD_SKIP_FIRST_RUN to opt-in (first-run experience off by default)#9260

Draft
tg-msft with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-review-comment-3632532677
Draft

fix: change AZD_SKIP_FIRST_RUN to opt-in (first-run experience off by default)#9260
tg-msft with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-review-comment-3632532677

Conversation

Copilot AI commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Addresses #9258: the first-run tool setup experience was prompting users unexpectedly. Changes the semantics so the experience is off by default and requires explicit opt-in via AZD_SKIP_FIRST_RUN=false.

Behavior change

AZD_SKIP_FIRST_RUN value Before After
unset first-run runs first-run skipped (default_disabled)
false first-run runs first-run runs
true first-run skipped first-run skipped

Background update checks keep the old semantics (unset = run); the asymmetry is intentional and documented.

Changes

  • tool_first_run.goshouldSkip() now returns skipReasonDefaultDisabled when AZD_SKIP_FIRST_RUN is unset or unparsable; added skipReasonDefaultDisabled = "default_disabled" constant; removed AZD_SKIP_FIRST_RUN=true from the in-experience help message (it no longer applies)
  • tool_update_check.go — added comment explaining the deliberate asymmetry with first-run
  • internal/tracing/fields/fields.go — added default_disabled to the documented example values for tool.firstrun.skip_reason
  • docs/environment-variables.md — updated AZD_SKIP_FIRST_RUN description to reflect new opt-in semantics
  • tool_first_run_test.go — tests now opt in via t.Setenv(envKeySkipFirstRun, "false"); unset-state setups use t.Setenv("") + os.Unsetenv (consistent with the clearCIVars pattern) rather than bare os.Unsetenv

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
20 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI and others added 2 commits July 22, 2026 18:15
…first-run experience

Co-authored-by: tg-msft <1179329+tg-msft@users.noreply.github.com>
…up in unset test cases

Co-authored-by: tg-msft <1179329+tg-msft@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix code as per review comment 3632532677 fix: change AZD_SKIP_FIRST_RUN to opt-in (first-run experience off by default) Jul 22, 2026
Copilot AI requested a review from tg-msft July 22, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants