Draft
fix: change AZD_SKIP_FIRST_RUN to opt-in (first-run experience off by default)#9260
Conversation
|
Azure Pipelines: 20 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
…first-run experience Co-authored-by: tg-msft <1179329+tg-msft@users.noreply.github.com>
…up in unset test cases Co-authored-by: tg-msft <1179329+tg-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code as per review comment 3632532677
fix: change AZD_SKIP_FIRST_RUN to opt-in (first-run experience off by default)
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #9258: the first-run tool setup experience was prompting users unexpectedly. Changes the semantics so the experience is off by default and requires explicit opt-in via
AZD_SKIP_FIRST_RUN=false.Behavior change
AZD_SKIP_FIRST_RUNvaluedefault_disabled)falsetrueBackground update checks keep the old semantics (unset = run); the asymmetry is intentional and documented.
Changes
tool_first_run.go—shouldSkip()now returnsskipReasonDefaultDisabledwhenAZD_SKIP_FIRST_RUNis unset or unparsable; addedskipReasonDefaultDisabled = "default_disabled"constant; removedAZD_SKIP_FIRST_RUN=truefrom the in-experience help message (it no longer applies)tool_update_check.go— added comment explaining the deliberate asymmetry with first-runinternal/tracing/fields/fields.go— addeddefault_disabledto the documented example values fortool.firstrun.skip_reasondocs/environment-variables.md— updatedAZD_SKIP_FIRST_RUNdescription to reflect new opt-in semanticstool_first_run_test.go— tests now opt in viat.Setenv(envKeySkipFirstRun, "false"); unset-state setups uset.Setenv("") + os.Unsetenv(consistent with theclearCIVarspattern) rather than bareos.Unsetenv