add examples for spring cloud function on Azure - #697
Merged
Conversation
kaibocai
requested review from
TsuyoshiUshio,
amamounelsayed,
anirudhgarg,
kamperiadis and
shreyas-gopalakrishna
as code owners
January 26, 2023 14:56
kaibocai
marked this pull request as draft
January 26, 2023 15:16
kaibocai
marked this pull request as ready for review
January 26, 2023 19:41
shreyas-gopalakrishna
previously approved these changes
Jan 27, 2023
shreyas-gopalakrishna
left a comment
shreyas-gopalakrishna
left a comment
Member
There was a problem hiding this comment.
Samples look good. I suggest we rename example directory to samples to match other Azure functions repositories.
https://github.com/Azure/azure-functions-host
https://github.com/Azure/azure-functions-dotnet-worker
shreyas-gopalakrishna
approved these changes
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
add examples for spring cloud function on Azure
Pull request checklist
release_notes.md