Skip to content

Reload environment variables on FunctionEnvironmentReloadRequest #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2020
Merged

Reload environment variables on FunctionEnvironmentReloadRequest #441

merged 1 commit into from
Mar 24, 2020

Conversation

@AnatoliB
Copy link
Contributor

@AnatoliB AnatoliB commented Mar 24, 2020

We need this to enable placeholders for PowerShell functions:

  • For placeholder purposes, the Functions Host starts language workers with a generic set of environment variables.
  • During specialization, the Functions Host sends a set of environment variables specific for the user app to the language worker, so that it has an opportunity to configure these variables without the need to restart.

Francisco-Gamino
Francisco-Gamino reviewed Mar 24, 2020
View reviewed changes
Francisco-Gamino
Francisco-Gamino approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@Francisco-Gamino Francisco-Gamino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment (clarification). Other than that, LGTM.

@AnatoliB AnatoliB merged commit 2b04f5b into Azure:dev Mar 24, 2020
@AnatoliB AnatoliB deleted the environment-reload branch March 24, 2020 16:13
AnatoliB added a commit that referenced this pull request Apr 28, 2020
@AnatoliB
Handle FunctionEnvironmentReloadRequest (#441)
33d83f4
AnatoliB added a commit that referenced this pull request Apr 28, 2020
@AnatoliB
Handle FunctionEnvironmentReloadRequest (#441)
3a7a8f6
AnatoliB added a commit that referenced this pull request Apr 28, 2020
@AnatoliB
Handle FunctionEnvironmentReloadRequest (#441)
07b923d
AnatoliB added a commit that referenced this pull request Apr 28, 2020
@AnatoliB
Handle FunctionEnvironmentReloadRequest (#441)
0c0ec1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Francisco-Gamino Francisco-Gamino Francisco-Gamino approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AnatoliB @Francisco-Gamino