Skip to content

Reload environment variables on FunctionEnvironmentReloadRequest #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Reload environment variables on FunctionEnvironmentReloadRequest #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/RequestProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,19 @@ internal StreamingMessage ProcessInvocationCancelRequest(StreamingMessage reques

internal StreamingMessage ProcessFunctionEnvironmentReloadRequest(StreamingMessage request)
{
var stopwatch = new Stopwatch();
stopwatch.Start();

var environmentReloadRequest = request.FunctionEnvironmentReloadRequest;
foreach (var (name, value) in environmentReloadRequest.EnvironmentVariables)
{
Environment.SetEnvironmentVariable(name, value);
}

var rpcLogger = new RpcLogger(_msgStream);
rpcLogger.SetContext(request.RequestId, null);
rpcLogger.Log(isUserOnlyLog: false, LogLevel.Trace, string.Format(PowerShellWorkerStrings.EnvironmentReloadCompleted, stopwatch.ElapsedMilliseconds));

StreamingMessage response = NewStreamingMessageTemplate(
request.RequestId,
StreamingMessage.ContentOneofCase.FunctionEnvironmentReloadResponse,
Expand Down
3 changes: 3 additions & 0 deletions src/resources/PowerShellWorkerStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,4 +313,7 @@
<data name="PowerShellVersion" xml:space="preserve">
<value>PowerShell version: '{0}'.</value>
</data>
<data name="EnvironmentReloadCompleted" xml:space="preserve">
<value>Environment reload completed in {0} ms.</value>
</data>
</root>