Skip AddProductWithDefaultPKTest for Javascript #392
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyzhang929
requested review from
Charles-Gagnon,
MaddyDev and
chlafreniere
as code owners
Charles-Gagnon
requested changes
Oct 12, 2022
Contributor
Charles-Gagnon
left a comment
Charles-Gagnon
left a comment
There was a problem hiding this comment.
The point of the tests is to test the local code so we can catch regressions before they go out. Could you look into the best way to do that?
Contributor
Author
|
Maybe we can copy the dll into the extension bundle in the pipeline as well. I'll look into that. |
Contributor
|
Might also want to ask the AF team to see if there's a better way to do this too. |
Contributor
Author
|
Opened #395 to address issue. |
Contributor
|
Make sure to delete the branch if you don't need this anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is failing for JavaScript since the extension bundle does not contain the fix for default columns yet. I manually updated the sql extension dll in my local extension bundle to verify that this test passes for JavaScript.
Created issue to re-enable: #393.